[PATCH] D88201: [DAGCombiner] Add decomposition patterns for Mul-by-Imm.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 18:31:25 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16079
+      return false;
+    if (isPowerOf2_64(Imm + 1) || isPowerOf2_64(Imm - 1) ||
+        isPowerOf2_64(1 - Imm) || isPowerOf2_64(-1 - Imm))
----------------
LONG_MAX+1 and LONG_MIN-1 are signed overflows. I fixed it in 2bd4730850cc0f3ab7bd0c51b18c0a220e480dc7


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88201/new/

https://reviews.llvm.org/D88201



More information about the llvm-commits mailing list