[PATCH] D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 15:35:24 PDT 2020


smeenai added a comment.

In D85140#2310910 <https://reviews.llvm.org/D85140#2310910>, @phosek wrote:

> Also a styling nit, this should have been `cmake/Modules`, not `cmake/modules`. The former is used only by LLVM and is a historic relic, all other projects use `cmake/Modules` which is more common in CMake-based builds.

FWIW, a bunch of other LLVM subprojects (Clang, LLD, MLIR, Flang, etc.) all appear to use `modules`. `Modules` appears to be used primarily by the runtimes (compiler-rt, libcxx, etc.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85140/new/

https://reviews.llvm.org/D85140



More information about the llvm-commits mailing list