[PATCH] D88252: z_Linux_asm.S modifications for arm64 (AARCH64) for Darwin/macOS

[Michael Pique via Phabricator via llvm-commits]

Michael_Pique updated this revision to Diff 297341.
Michael_Pique added a comment.

Now guarding the .size directive with #if __ELF__ as suggested. Tested on arm64 Darwin. Unable to test on arm64 Linux as have no such system available.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88252/new/

https://reviews.llvm.org/D88252

Files:
  z_Linux_asm_ifelf.S


Index: z_Linux_asm_ifelf.S
===================================================================
--- z_Linux_asm_ifelf.S
+++ z_Linux_asm_ifelf.S
@@ -1746,10 +1746,12 @@
     .comm .gomp_critical_user_,32,8
     .data
     .align 8
-    .global __kmp_unnamed_critical_addr
-__kmp_unnamed_critical_addr:
+    .global KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr)
+KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr):
     .8byte .gomp_critical_user_
-    .size __kmp_unnamed_critical_addr,8
+#if __ELF__
+    .size KMP_PREFIX_UNDERSCORE(__kmp_unnamed_critical_addr),8
+#endif
 #endif /* KMP_ARCH_PPC64 || KMP_ARCH_AARCH64 || KMP_ARCH_MIPS64 ||
           KMP_ARCH_RISCV64 */
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88252.297341.patch
Type: text/x-patch
Size: 677 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201009/43c182d4/attachment.bin>