[PATCH] D88921: [MemCpyOpt] Fix thread-safety of call slot opimization

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 14:50:49 PDT 2020


efriedma added a comment.

> To clarify, the suggestion here is to add a boolean flag to callCapturesBefore() that determines whether arguments should always be considered capturing?

Something like that.

> One thing to note is that this would not allow us to treat the call modref check (which does not care about noalias arguments) and the willreturn check (which does) separately. That is, the following code would no longer fold:

I guess if we cared, we could make callCapturesBefore() return two results, instead of adding a boolean argument.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88921/new/

https://reviews.llvm.org/D88921



More information about the llvm-commits mailing list