[PATCH] D89075: [AArch64][GlobalISel] Regbankselect reductions to use FPR bank for scalars.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

Might want to add these to `isPreISelGenericFloatingPointOpcode` while we're here.



================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64RegisterBankInfo.cpp:895
+    // FPR bank.
+    OpRegBankIdx[0] = PMI_FirstFPR;
+    OpRegBankIdx[1] = PMI_FirstFPR;
----------------
Slightly simpler:

`OpRegBankIdx = {PMI_FirstFPR, PMI_FirstFPR}`


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64RegisterBankInfo.cpp:902
+    // Assign them FPR for now.
+    OpRegBankIdx[0] = PMI_FirstFPR;
+    OpRegBankIdx[1] = PMI_FirstFPR;
----------------
`OpRegBankIdx = {PMI_FirstFPR, PMI_FirstFPR, PMI_FirstFPR}`?


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/regbankselect-reductions.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc -mtriple=aarch64-unknown-unknown -verify-machineinstrs -O0 -run-pass=regbankselect -global-isel-abort=1 %s -o - | FileCheck %s
+
----------------
Probably don't need -O0


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89075/new/

https://reviews.llvm.org/D89075