[PATCH] D88988: [llvm-symbolizer] Add inline stack traces for Windows.

[Amy Huang via Phabricator via llvm-commits]

akhuang added a comment.

In D88988#2320393 <https://reviews.llvm.org/D88988#2320393>, @amccarth wrote:

> - The test turns a small stack into file+line numbers.  Is that sufficient or should there also be one to get function name+offsets?

Doesn't it also have function names? The asan tests will also be providing some test coverage for this.

In D88988#2320393 <https://reviews.llvm.org/D88988#2320393>, @amccarth wrote:

> I'll be curious to hear what you figure out about the ASAN tests.

I think most of them are probably windows tests that don't expect inline stack frames, but I haven't actually fixed any of them yet.

There are also some non windows-specific tests that are failing because the windows inline stack frames are apparently different from the linux ones (e.g. compiler-rt/test/asan/TestCases/calloc-overflow.cpp). Seems like the first line on the linux stack trace is a macro, and in the windows stack trace the first line is a function that was in the macro.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88988/new/

https://reviews.llvm.org/D88988