[PATCH] D78778: Add SupportsDebugUnwindInformation to MCAsmInfo

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 09:58:16 PDT 2020


scott.linder added a comment.

In D78778#2301702 <https://reviews.llvm.org/D78778#2301702>, @probinson wrote:

> I was not aware that `.eh_frame` needed to be an ALLOC section, although it makes sense now that you say it; thanks for that!
>
> I don't feel qualified to approve this, but any reviewer will tell you:  Needs a test.

I can't seem to find another example of a test of an MCAsmInfo option, at least not without a target which sets it. I suppose a UnitTest which derives a new class from MCAsmInfo could work, but then I wonder why this hasn't been needed for any of the other options.

The tests in https://reviews.llvm.org/D76879 do exercise this, and it seemed like it would be easier to review as two separate commits. The current phabricator "stack" doesn't express the dependencies perfect here, I can move it around some to make it more clear.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78778/new/

https://reviews.llvm.org/D78778



More information about the llvm-commits mailing list