[PATCH] D89108: [NFC] Add the getSize() interface for MachineConstantPoolValue

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

TOC is a step forward from GOT for which one can control the layout. This kind of optimizations should be done (otherwise we can generate `@got` in the first place).



================
Comment at: llvm/include/llvm/CodeGen/MachineConstantPool.h:48
 
+  /// getSize - get the size of this MachineConstantPoolValue.
+  ///
----------------
`Name -` is deprecated in the coding standard. Please drop.

Actually the function name self explains so perhaps the comment can be omitted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89108/new/

https://reviews.llvm.org/D89108