[PATCH] D88872: [Coroutines] Refactor/Rewrite Spill and Alloca processing

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 08:33:38 PDT 2020


lxfind added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1104
 
-    // If we have not seen this GEP instruction, migrate any dbg.declare from
-    // the alloca to it.
----------------
ChuanqiXu wrote:
> I'm confusing about the comment. It says it would migrate dbg.declare from alloca. But how could it know the `CurrentValue` must be alloca from the context ?
I think dbg.declare instructions were all generated for alloca instructions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88872/new/

https://reviews.llvm.org/D88872



More information about the llvm-commits mailing list