[PATCH] D89058: [LoopInterchange][NewPM] Port -loop-interchange to NPM

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thanks



================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopInterchange.h:1
+//===- LoopInterchange.h - Loop rerolling pass ----------------------------===//
+//
----------------
Needs updating to `Loop interchange pass` or something?


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopInterchange.h:17
+
+class Function;
+
----------------
unneeded?


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopInterchange.h:20
+class LoopInterchangePass : public PassInfoMixin<LoopInterchangePass> {
+public:
+  PreservedAnalyses run(Loop &L, LoopAnalysisManager &AM,
----------------
nit: I think the style guide suggest using `struct` instead of `class`, if the first/all members are public.


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:1634
 
-char LoopInterchange::ID = 0;
+// Main LoopInterchange Pass.
+struct LoopInterchangeLegacyPass : public LoopPass {
----------------
nit: `///` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89058/new/

https://reviews.llvm.org/D89058