[PATCH] D86278: [compiler-rt][builtins] Add tests for atomic builtins support functions

Fri Oct 9 02:17:46 PDT 2020

luismarques added a comment.

In D86278#2319808 <https://reviews.llvm.org/D86278#2319808>, @efriedma wrote:

> Under what circumstances does this test actually get built?  By default, the builtins library doesn't provide these functions, so this will fail to link.

This test is gated on `REQUIRES: librt_has_atomic`. For the relevant platforms, I would configure Compiler-RT with `-DCOMPILER_RT_HAS_ATOMIC_KEYWORD=ON -DCOMPILER_RT_EXCLUDE_ATOMIC_BUILTIN=OFF` and the test would run and link successfully. IIRC, by default `COMPILER_RT_EXCLUDE_ATOMIC_BUILTIN` is set to YES, so the test is not run, so there shouldn't be any unexpected linking failures (if you found such a case please let me know).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86278/new/

https://reviews.llvm.org/D86278