[PATCH] D89076: AMDGPU: Update AMDHSA code object version handling

Thu Oct 8 17:29:27 PDT 2020

t-tye accepted this revision.
t-tye added inline comments.
This revision is now accepted and ready to land.

================
Comment at: clang/docs/ClangCommandLineReference.rst:179

+.. option:: -dsym-dir<dir>
+
----------------
scott.linder wrote:
> There seem to be a lot of unrelated changes here; does the patch need to be rebased? Or are you just cleaning up the whole file?
> 
> If the latter could these be in a separate diff?
Many changes in this file are the result of earlier changes in the options.td file not updating this file with the build result. So suggest submitting a review for updating this file without the code version changes first. Then the changes to this file in this review will just be code object version related.

Otherwise I think all the changes in this review are related to cleaning up the handling of the existing V2 and V3 code object formats in preparation for submitting the V4 code object changes.

================
Comment at: llvm/docs/AMDGPUUsage.rst:901

-Code Object V2 Note Records (-mattr=-code-object-v3)
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Code Object V2 Note Records (--amdhsa-code-object-version=2)
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
----------------
Were there also cleanup in the ELF section that describes the e_flags and defines the usage of the new --amdhsa-code-object-version option?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89076/new/

https://reviews.llvm.org/D89076