[llvm] 0716805 - [SLP] optimizeGatherSequence - assert every Instruction in the worklist is non-null.

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2020-10-08T20:02:18+01:00
New Revision: 0716805c02a7ddc8fb2323444f022d3aa47055d3

URL: https://github.com/llvm/llvm-project/commit/0716805c02a7ddc8fb2323444f022d3aa47055d3
DIFF: https://github.com/llvm/llvm-project/commit/0716805c02a7ddc8fb2323444f022d3aa47055d3.diff

LOG: [SLP] optimizeGatherSequence - assert every Instruction in the worklist is non-null.

Fixes clang static analyzer warning.

Added: 
    

Modified: 
    llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
index 0f60d60726f2..ce546045e456 100644
--- a/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ b/llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -4919,7 +4919,8 @@ void BoUpSLP::optimizeGatherSequence() {
   // instructions into 
diff erent buckets based on the insert lane.
   SmallVector<Instruction *, 16> Visited;
   for (auto I = CSEWorkList.begin(), E = CSEWorkList.end(); I != E; ++I) {
-    assert((I == CSEWorkList.begin() || !DT->dominates(*I, *std::prev(I))) &&
+    assert(*I &&
+           (I == CSEWorkList.begin() || !DT->dominates(*I, *std::prev(I))) &&
            "Worklist not sorted properly!");
     BasicBlock *BB = (*I)->getBlock();
     // For all instructions in blocks containing gather sequences: