[PATCH] D85024: [llvm-objdump] Implement --prefix option

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix.test:8
+; RUN: llvm-objdump --prefix myprefix --source %t-relative-path.o 2>&1 | \
+; RUN:   FileCheck %s --check-prefix CHECK-BROKEN-PREFIX -DFILE=%t-relative-path.o -DPREFIX=.
+; CHECK-BROKEN-PREFIX: warning: '[[FILE]]': failed to find source [[PREFIX]]/Inputs/source-interleave-x86_64.c
----------------
Since you have used `=` as the separator of a long option, consider changing `--check-prefix ` to `--check-prefix=`


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1039
+  if (!Prefix.empty()) {
+    if (sys::path::is_absolute_gnu(LineInfo.FileName)) {
+      SmallString<128> FilePath;
----------------
The two `if` can be merged


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.h:51
 extern cl::opt<bool> UnwindInfo;
+extern cl::opt<std::string> Prefix;
 
----------------
Sort in an alphabetical order.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85024/new/

https://reviews.llvm.org/D85024