[PATCH] D88832: [TableGen] Add new getAllDerivedDefinitionsTwo function to RecordKeeper
Paul C. Anagnostopoulos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 8 09:52:51 PDT 2020
Paul-C-Anagnostopoulos marked 7 inline comments as done.
Paul-C-Anagnostopoulos added inline comments.
================
Comment at: llvm/lib/TableGen/Record.cpp:2493-2500
+ AddDef = true;
+ for (auto *const Class : ClassRecs)
+ if (!OneDef.second->isSubClassOf(Class)) {
+ AddDef = false;
+ break;
+ }
+ if (AddDef)
----------------
jrtc27 wrote:
> This can avoid some boilerplate by using llvm::any_of
Ah, something new to learn. Okay, I'll check it out.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88832/new/
https://reviews.llvm.org/D88832
More information about the llvm-commits
mailing list