[PATCH] D89038: [PatternMatch] Add new FP matchers. NFC.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 06:50:01 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:3665
         continue;
-      auto *CElt = dyn_cast<ConstantFP>(Elt);
-      if (!CElt || CElt->isNaN())
+      if (!match(Elt, m_NonNaN()))
         return false;
----------------
Would it be better to simplify this entire loop to match(V, m_NonNaN()) ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89038/new/

https://reviews.llvm.org/D89038



More information about the llvm-commits mailing list