[PATCH] D85024: [llvm-objdump] Implement --prefix option

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, aside from some smaller formatting bits, but please wait for others.



================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix.test:3
+
+;; Test prefix option ignored in relative paths.
+
----------------



================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix.test:19
+
+;; Test valid source interleave being broken by adding an incorrect prefix.
+
----------------



================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-prefix.test:31-32
+; RUN: llc -o %t-malformed.o -filetype=obj -mtriple=x86_64-pc-linux %t-malformed.ll
+; RUN: llvm-objdump --prefix myprefix --source %t-malformed.o 2>&1 \
+; RUN:   | FileCheck %s --check-prefix CHECK-MALFORMED -DFILE=%t-malformed.o
+; CHECK-MALFORMED: warning: '[[FILE]]': failed to parse debug information for [[FILE]]
----------------
Here and elsewhere, my personal preference is to format it as in the suggested edit. The motivation is 1) The first line clearly indicates that there is no more of the specific command indicated by that line, whilst 2) the indentation on the second line shows the line is a continuation of the previous line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85024/new/

https://reviews.llvm.org/D85024