[PATCH] D85024: [llvm-objdump] Implement --prefix option

[Vinicius Tinti via Phabricator via llvm-commits]

tinti marked 6 inline comments as done.
tinti added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-absolute-paths-all.test:3-10
+; RUN: sed -e "s,SRC_COMPDIR,/Inputs,g" %p/Inputs/source-interleave.ll > %t.ll
+; RUN: llc -o %t.o -filetype=obj -mtriple=x86_64-pc-linux %t.ll
+
+; RUN: sed -e "s,SRC_COMPDIR,%/p/Inputs,g" %p/Inputs/source-interleave.ll > %t2.ll
+; RUN: llc -o %t2.o -filetype=obj -mtriple=x86_64-pc-linux %t2.ll
+
+; RUN: sed -e "s,SRC_COMPDIR,,g" %p/Inputs/source-interleave.ll | sed -e "s,filename: \"source-interleave-x86_64.c\",filename: \"\",g"> %t3.ll
----------------
jhenderson wrote:
> I'd prefer it if you created these inputs immediately before their first use rather than early on. It would also be good if you named the output files according to the property they are trying to show.
Good point.


================
Comment at: llvm/test/tools/llvm-objdump/X86/source-interleave-absolute-paths-non-windows.test:1
+;; Test --prefix option non Windows specific behavior.
+; UNSUPPORTED: system-windows
----------------
jhenderson wrote:
> This comment is ambiguous - it could imply behaviour that is not specific to Windows, which would also apply to the generic tests in the -all test.
I am struggling to find a good comment here.

Can I use 'POSIX' or 'unix-like' behavior? If yes, I would also rename the properly. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85024/new/

https://reviews.llvm.org/D85024