[PATCH] D85140: [RFC] Factor out repetitive cmake patterns for llvm-style projects

[Paul Osmialowski via Phabricator via llvm-commits]

pawelo12345678 added a comment.

Does this one have potential to fix following issues while building MLIR?:

  [ 81%] Building CXX object tools/mlir/lib/Conversion/LinalgToLLVM/CMakeFiles/obj.MLIRLinalgToLLVM.dir/LinalgToLLVM.cpp.o
  cd /home/pawelo/llvm-project.git/build-shared-release/tools/mlir/lib/Conversion/LinalgToLLVM && /usr/lib/llvm/10/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=0 -DMLIR_ROCM_CONVERSIONS_ENABLED=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_M
  ACROS -I/home/pawelo/llvm-project.git/build-shared-release/tools/mlir/lib/Conversion/LinalgToLLVM -I/home/pawelo/llvm-project.git/mlir/lib/Conversion/LinalgToLLVM -I/home/pawelo/llvm-project.git/build-shared-release/include -I/home/pawelo/llvm-project.git/llvm/include -I/home/pawelo/llvm-project.git/mlir/include -I
  /home/pawelo/llvm-project.git/build-shared-release/tools/mlir/include -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wc
  overed-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -ffunction-sections -fdata-sections -Werror=global-constructors -O3   -fno-exceptions -fno-rtti -UNDEBUG -std=c++17 -o CMakeFiles/obj.MLIRLinalgToLLVM.dir/LinalgToLLVM.cpp.o -c /home/pawelo/llvm-project.git/mli
  r/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
  In file included from /home/pawelo/llvm-project.git/mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp:21:
  /home/pawelo/llvm-project.git/mlir/include/mlir/Dialect/Linalg/Passes.h:67:10: fatal error: 'mlir/Dialect/Linalg/Passes.h.inc' file not found
  #include "mlir/Dialect/Linalg/Passes.h.inc"
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 error generated.

...or:

  [ 70%] Building CXX object tools/mlir/lib/Dialect/LLVMIR/CMakeFiles/obj.MLIRLLVMIR.dir/IR/LLVMDialect.cpp.o
  cd /home/pawelo/llvm-project.git/build-shared-release/tools/mlir/lib/Dialect/LLVMIR && /usr/lib/llvm/10/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -DMLIR_CUDA_CONVERSIONS_ENABLED=0 -DMLIR_ROCM_CONVERSIONS_ENABLED=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/
  home/pawelo/llvm-project.git/build-shared-release/tools/mlir/lib/Dialect/LLVMIR -I/home/pawelo/llvm-project.git/mlir/lib/Dialect/LLVMIR -I/home/pawelo/llvm-project.git/build-shared-release/include -I/home/pawelo/llvm-project.git/llvm/include -I/home/pawelo/llvm-project.git/mlir/include -I/home/pawelo/llvm-project.g
  it/build-shared-release/tools/mlir/include -stdlib=libc++ -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-
  noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -ffunction-sections -fdata-sections -Werror=global-constructors -O3   -fno-exceptions -fno-rtti -UNDEBUG -std=c++17 -o CMakeFiles/obj.MLIRLLVMIR.dir/IR/LLVMDialect.cpp.o -c /home/pawelo/llvm-project.git/mlir/lib/Dialect/LLVMIR/IR/LLVMDia
  lect.cpp
  In file included from /home/pawelo/llvm-project.git/mlir/lib/Dialect/LLVMIR/IR/LLVMDialect.cpp:13:
  In file included from /home/pawelo/llvm-project.git/mlir/include/mlir/Dialect/LLVMIR/LLVMDialect.h:18:
  /home/pawelo/llvm-project.git/mlir/include/mlir/Dialect/OpenMP/OpenMPDialect.h:19:10: fatal error: 'mlir/Dialect/OpenMP/OpenMPOpsDialect.h.inc' file not found
  #include "mlir/Dialect/OpenMP/OpenMPOpsDialect.h.inc"
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1 error generated.

It occurs on every build since June/July. I guess it's because I'm using plain `cmake`, not `ninja`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85140/new/

https://reviews.llvm.org/D85140