[PATCH] D88824: [Support][unittests] Enforce alignment in ConvertUTFTest
Rainer Orth via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Oct 8 01:39:17 PDT 2020
ro added a comment.
In D88824#2318568 <https://reviews.llvm.org/D88824#2318568>, @efriedma wrote:
> Why are we trying to enforce alignment like this in the first place? Writing an API that expects an overaligned ArrayRef<char> is just asking for trouble. There should be two possibilities:
Agreed: the current interface is fundamentally flawed. However, I have no idea which of your suggested alternatives is better; my primary concern is getting the Solaris/sparcv9 results clean...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88824/new/
https://reviews.llvm.org/D88824
More information about the llvm-commits
mailing list