[PATCH] D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 01:38:41 PDT 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one outstanding nit.



================
Comment at: llvm/test/tools/llvm-readobj/COFF/tls-directory.test:3
+
+## Test that the output of --coff-tls-directory works on x86
+## The binary created from this yaml definition is such that .rdata contains
----------------
jhenderson wrote:
> 
This hasn't been addressed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88635/new/

https://reviews.llvm.org/D88635



More information about the llvm-commits mailing list