[PATCH] D88468: [llvm-readobj] Don't print out section names for STABS symbols

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 01:18:49 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/MachO/stabs.yaml:100
+    - n_strx:          2
+      n_type:          0x64 # N_SO
+      n_sect:          0
----------------
jhenderson wrote:
> int3 wrote:
> > grimar wrote:
> > > `##` -> `#` here and below.
> > > 
> > > (We should be consistent in marking comments).
> > Did you mean `#` -> `##`?
> I think that's what he meant - comments should use `##`.
Yes :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88468/new/

https://reviews.llvm.org/D88468



More information about the llvm-commits mailing list