[PATCH] D89004: [LLD] [COFF] Implement a GNU/ELF like -wrap option

[Orgad Shaneh via Phabricator via llvm-commits]

orgads added a comment.

Thank you very much!

I'll try to test it next week.



================
Comment at: lld/COFF/Driver.cpp:2012
 
+  // Create wrapped symbols for --wrap option.
+  std::vector<WrappedSymbol> wrapped = addWrappedSymbols(args);
----------------
-wrap?


================
Comment at: lld/COFF/Driver.cpp:2061
 
+  // Apply symbol renames for --wrap.
+  if (!wrapped.empty())
----------------
ditto


================
Comment at: lld/COFF/MinGW.cpp:194
+// that LTO won't eliminate them.
+std::vector<lld::coff::WrappedSymbol>
+lld::coff::addWrappedSymbols(opt::InputArgList &args) {
----------------
You have using namespace lld::coff. Remove the qualifiers? (repeats below)


================
Comment at: lld/test/MinGW/driver.test:285
+
+RUN: ld.lld -### -m i386pep foo.o -wrap foo1 --wrap foo2 | FileCheck -check-prefix WRAP %s
+RUN: ld.lld -### -m i386pep foo.o -wrap=foo1 --wrap=foo2 | FileCheck -check-prefix WRAP %s
----------------
-wrap foo2?


================
Comment at: lld/test/MinGW/driver.test:286
+RUN: ld.lld -### -m i386pep foo.o -wrap foo1 --wrap foo2 | FileCheck -check-prefix WRAP %s
+RUN: ld.lld -### -m i386pep foo.o -wrap=foo1 --wrap=foo2 | FileCheck -check-prefix WRAP %s
+WRAP: -wrap:foo1 -wrap:foo2
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89004/new/

https://reviews.llvm.org/D89004