[PATCH] D88684: llvm-reduce: Don't replace intrinsic calls with undef
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 7 18:46:01 PDT 2020
dblaikie added a comment.
In D88684#2318361 <https://reviews.llvm.org/D88684#2318361>, @arsenm wrote:
> In D88684#2318108 <https://reviews.llvm.org/D88684#2318108>, @ychen wrote:
>
>> The test tieing to AMDGPU seems less ideal for general functionality. I've seen llvm.dbg.value caused the same problem, maybe we could use that?
>
> The debug intrinsics require a *lot* of metadata overhead simply to satsify the operations. The other metadata using intrinsics are experimental, so this seemed like the least fragile way to test it
Given the functionality isn't implemented in terms of metadata-using-intrinsics in particular, a test using some non-metadata-using intrinsic would be fine.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88684/new/
https://reviews.llvm.org/D88684
More information about the llvm-commits
mailing list