[PATCH] D89020: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`.

Wed Oct 7 18:44:22 PDT 2020

delcypher marked an inline comment as done.
delcypher added inline comments.

================
Comment at: llvm/utils/lit/tests/googletest-timeout.py:30
+# RUN:   > %t.cmdover.out 2> %t.cmdover.err
+# RUN: FileCheck --check-prefix=CHECK-INF < %t.cmdover.out %s
 # RUN: FileCheck --check-prefix=CHECK-CMDLINE-OVERRIDE-ERR < %t.cmdover.err %s
----------------
yln wrote:
> Other than checking the debug output on stderr ("Forcing timeout to be 2 seconds") this test actually does not have a reliable way of *really* checking that the timeout was 2 (and not 1).  (without making it flaky as in our original problem)
> 
> So we could let this test pass immediately (make it fast!) by setting a large timeout override, checking stderr for that value ("Forcing timeout to be 3600 seconds") and use `QuickSubTest` to pass the test immediately.
Very true I've updated the tests to take this approach.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89020/new/

https://reviews.llvm.org/D89020