[PATCH] D89020: [lit] Try to remove the flakeyness of `shtest-timeout.py` and `googletest-timeout.py`.

Julian Lettner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 17:58:00 PDT 2020


yln added inline comments.


================
Comment at: llvm/utils/lit/tests/shtest-timeout.py:57
 
 # CHECK-CMDLINE-OVERRIDE-ERR: Forcing timeout to be 2 seconds
 
----------------
Same suggestion as above: only check timeout is really the debug message on stderr.

But that doesn't require the test to fail.  We could immediately pass it instead of hanging for 2 seconds.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89020/new/

https://reviews.llvm.org/D89020



More information about the llvm-commits mailing list