[PATCH] D87001: [IRMover] Avoid materializing global value that belongs to not-yet-linked module

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

LGTM with a minor comment nit and some clarification needed about stage 2 vs stage 3 in the description as noted below.



================
Comment at: llvm/test/LTO/X86/Inputs/type-mapping-bug4_1.ll:29
+  ; (stage3.2)
+  ;   mapping `!6` starts the stage2, during which second instance of %class.CB (%class.CB.1)
+  ;   is created for the mapped @d declaration.
----------------
This mentions stage2, seems inconsistent with stage3.2?


================
Comment at: llvm/test/LTO/X86/type-mapping-bug4.ll:10
+; stage2: during linking t1, mapping @d
+; stage3: linking t2
+; All stages except stage0 are described in type-mapping-bug4_1.ll. Stage0 is
----------------
nit "t2.o" here and t1.o on the line above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87001/new/

https://reviews.llvm.org/D87001