[PATCH] D88460: Strlen loop idiom recognition

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1691
+  }
+  if (!ResInst)
+    return false;
----------------
anjankgk wrote:
> efriedma wrote:
> > I'm not sure how ResInst is connected to the rest of this transform; why are we transforming the operand of some random PHI node?
> I added a comment for clarity - 
>   // Finally, we find the phi node that corresponds to the distance between the
>   // pointers and replace it's uses by the call to strlen in the transformed
>   // code.
> 
The patch doesn't appear to prove that anywhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88460/new/

https://reviews.llvm.org/D88460