[PATCH] D88460: Strlen loop idiom recognition

Anjan Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 15:15:32 PDT 2020


anjankgk marked 4 inline comments as done.
anjankgk added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:1691
+  }
+  if (!ResInst)
+    return false;
----------------
efriedma wrote:
> I'm not sure how ResInst is connected to the rest of this transform; why are we transforming the operand of some random PHI node?
I added a comment for clarity - 
  // Finally, we find the phi node that corresponds to the distance between the
  // pointers and replace it's uses by the call to strlen in the transformed
  // code.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88460/new/

https://reviews.llvm.org/D88460



More information about the llvm-commits mailing list