[PATCH] D88764: [NewPM] Use PassInstrumentation for -verify-each

[Yuanfang Chen via Phabricator via llvm-commits]

ychen added a comment.

Nice cleanup!



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:741
+          if (DebugLogging)
+            dbgs() << "Verifying function " << F->getName() << "\n";
+
----------------
To encode more information in the output, how about adding the suffix "for loop <loop name>" for loop pass?

Ditto for cgscc pass. Also, check the full string such as "Verifying module <x>", "Verifying module <x> for loop <y>" etc.


================
Comment at: llvm/test/Other/new-pass-manager-verify-each.ll:4
+; Added manually by opt at beginning
+; CHECK: Running pass: VerifierPass
+
----------------
If it is not added by VerifyInstrumentation, maybe we don't need to check it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88764/new/

https://reviews.llvm.org/D88764