[PATCH] D88991: [LLD] Ignore ELF tests when ld.lld defaults to MinGW
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 7 14:32:07 PDT 2020
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
In D88991#2317849 <https://reviews.llvm.org/D88991#2317849>, @mstorsjo wrote:
> Looks sensible to me, but I'd defer to @MaskRay to approve.
>
> I wonder if it'd be possible to add some custom substitution in the lit config, to have it replace `ld.lld` with `ld.lld -m <some-elf>` in this case... Or does that fail if `-m` is explicitly specified but turns out to be the wrong architecture compared to what the test actually does?
There will be an error `... is incompatible with ...` with an object file with a wrong architecture.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88991/new/
https://reviews.llvm.org/D88991
More information about the llvm-commits
mailing list