[PATCH] D89009: Add version to libLLVM also on non UNIX

Mateusz MikuĊ‚a via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 14:25:06 PDT 2020


mati865 created this revision.
mati865 added reviewers: hans, mstorsjo, LLVM.
mati865 added a project: LLVM.
Herald added subscribers: llvm-commits, mgorny.
mati865 requested review of this revision.

As discussed in https://reviews.llvm.org/D87521

llvm-config expects versioned library regardless of platform.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89009

Files:
  llvm/cmake/modules/AddLLVM.cmake


Index: llvm/cmake/modules/AddLLVM.cmake
===================================================================
--- llvm/cmake/modules/AddLLVM.cmake
+++ llvm/cmake/modules/AddLLVM.cmake
@@ -596,7 +596,7 @@
     endif()
   endif()
 
-  if(ARG_SHARED AND UNIX)
+  if(ARG_SHARED)
     if(NOT APPLE AND ARG_SONAME)
       get_target_property(output_name ${name} OUTPUT_NAME)
       if(${output_name} STREQUAL "output_name-NOTFOUND")


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89009.296769.patch
Type: text/x-patch
Size: 425 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201007/dee05beb/attachment.bin>


More information about the llvm-commits mailing list