[PATCH] D89008: [LLD] [ELF] Fix up a comment regarding the --wrap option. NFC.
Martin Storsjö via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 7 14:20:01 PDT 2020
mstorsjo created this revision.
mstorsjo added reviewers: MaskRay, grimar.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.
mstorsjo requested review of this revision.
Add missing leading underscores to the `__wrap_<symbol>` and `__real_<symbol>` names.
The comments regarding the option also seem to use inconsistent spelling, both `-wrap` and `--wrap` occur - but I didn't change that bit here.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D89008
Files:
lld/ELF/Driver.cpp
Index: lld/ELF/Driver.cpp
===================================================================
--- lld/ELF/Driver.cpp
+++ lld/ELF/Driver.cpp
@@ -1837,9 +1837,9 @@
// The --wrap option is a feature to rename symbols so that you can write
// wrappers for existing functions. If you pass `-wrap=foo`, all
-// occurrences of symbol `foo` are resolved to `wrap_foo` (so, you are
-// expected to write `wrap_foo` function as a wrapper). The original
-// symbol becomes accessible as `real_foo`, so you can call that from your
+// occurrences of symbol `foo` are resolved to `__wrap_foo` (so, you are
+// expected to write `__wrap_foo` function as a wrapper). The original
+// symbol becomes accessible as `__real_foo`, so you can call that from your
// wrapper.
//
// This data structure is instantiated for each -wrap option.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89008.296790.patch
Type: text/x-patch
Size: 827 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201007/45250edd/attachment.bin>
More information about the llvm-commits
mailing list