[PATCH] D89006: [LLD] [COFF] Fix a condition that was missed in 7f0e6c31c255

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: rnk.
Herald added a subscriber: dexonsmith.
Herald added a project: LLVM.
mstorsjo requested review of this revision.

This should fix cases when e.g. auto import is enabled without mingw mode in total being enabled, in combination with LTO.

Not sure if it's worth adding a testcase for this, as it's mostly a benign consistency issue leftover from that commit.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D89006

Files:
  lld/COFF/SymbolTable.cpp


Index: lld/COFF/SymbolTable.cpp
===================================================================
--- lld/COFF/SymbolTable.cpp
+++ lld/COFF/SymbolTable.cpp
@@ -402,7 +402,7 @@
     }
     if (name.contains("_PchSym_"))
       continue;
-    if (config->mingw && impSymbol(name))
+    if (config->autoImport && impSymbol(name))
       continue;
     undefs.insert(sym);
   }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D89006.296788.patch
Type: text/x-patch
Size: 376 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201007/2a7fbc48/attachment.bin>