[PATCH] D87148: [ImplicitNullCheck] Handle Nonzero faulting pages and complex addressing

Wed Oct 7 13:05:41 PDT 2020

anna marked 5 inline comments as done.
anna added inline comments.

================
Comment at: llvm/test/CodeGen/X86/implicit-null-check.ll:625
+; CHECK:       ## %bb.0: ## %entry
+; CHECK:         movq 3526(,%rdi,8), %rax ## on-fault: LBB23_1
+; CHECK-NEXT:  ## %bb.2: ## %not_null
----------------
reames wrote:
> You don't appear to actually have a test here which uses a displacement large enough to need a base register, please add one.
> 
> (i.e. modify this test to add not 3526, but 0xFFFFF0000 (or something similarly large)
I have a test in the negative test cases file above where the displacement is large and outside the faulting page. I'll modify it to a very large value so that it is in a register and not an immediate. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87148/new/

https://reviews.llvm.org/D87148