[PATCH] D88990: Update documentation on stage3 cmake build

[serge via Phabricator via llvm-commits]

serge-sans-paille updated this revision to Diff 296773.
serge-sans-paille added a comment.

APPLE-specific setting wrt linker


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88990/new/

https://reviews.llvm.org/D88990

Files:
  clang/cmake/caches/3-stage-base.cmake
  llvm/docs/AdvancedBuilds.rst


Index: llvm/docs/AdvancedBuilds.rst
===================================================================
--- llvm/docs/AdvancedBuilds.rst
+++ llvm/docs/AdvancedBuilds.rst
@@ -186,8 +186,6 @@
 .. code-block:: console
 
   $ cmake -G Ninja -C <path_to_clang>/cmake/caches/3-stage.cmake <source dir>
-  $ ninja stage3
+  $ cmake --build . --target stage3 --parallel
 
-After the build you can compare the stage2 & stage3 compilers. We have a bot
-setup `here <http://lab.llvm.org:8011/builders/clang-3stage-ubuntu>`_ that runs
-this build and compare configuration.
+After the build you can compare the stage2 & stage3 compilers.
Index: clang/cmake/caches/3-stage-base.cmake
===================================================================
--- clang/cmake/caches/3-stage-base.cmake
+++ clang/cmake/caches/3-stage-base.cmake
@@ -3,6 +3,15 @@
 set(LLVM_BUILD_EXTERNAL_COMPILER_RT ON CACHE BOOL "")
 set(BOOTSTRAP_LLVM_ENABLE_LTO ON CACHE BOOL "")
 
+# Use LLD do have less requirements on system linker, unless we're on an apple
+# platform where the system compiler is to be prefered.
+if(APPLE)
+    set(BOOTSTRAP_LLVM_ENABLE_LLD OFF CACHE BOOL "")
+else()
+    set(BOOTSTRAP_LLVM_ENABLE_LLD ON CACHE BOOL "")
+endif()
+
+
 set(CLANG_BOOTSTRAP_TARGETS
   clang
   check-all


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88990.296773.patch
Type: text/x-patch
Size: 1273 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201007/b4a7be93/attachment.bin>