[PATCH] D88996: Set the default for -bbsections-cold-text-prefix to .text.split.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish created this revision.
snehasish added reviewers: tmsriram, echristo.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
snehasish requested review of this revision.

After using this for a while, we find that it is generally useful to
have it set to .text.split. by default, removing the need for an
additional -mllvm option.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88996

Files:
  llvm/lib/CodeGen/BasicBlockSections.cpp


Index: llvm/lib/CodeGen/BasicBlockSections.cpp
===================================================================
--- llvm/lib/CodeGen/BasicBlockSections.cpp
+++ llvm/lib/CodeGen/BasicBlockSections.cpp
@@ -81,12 +81,12 @@
 
 // Placing the cold clusters in a separate section mitigates against poor
 // profiles and allows optimizations such as hugepage mapping to be applied at a
-// section granularity. Where necessary, users should set this to ".text.split."
-// which is recognized by lld via the `-z keep-text-section-prefix` flag.
+// section granularity. Defaults to ".text.split." which is recognized by lld
+// via the `-z keep-text-section-prefix` flag.
 cl::opt<std::string> llvm::BBSectionsColdTextPrefix(
     "bbsections-cold-text-prefix",
     cl::desc("The text prefix to use for cold basic block clusters"),
-    cl::init(".text.unlikely."), cl::Hidden);
+    cl::init(".text.split."), cl::Hidden);
 
 namespace {
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88996.296758.patch
Type: text/x-patch
Size: 935 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201007/02c4a551/attachment.bin>