[PATCH] D88932: [runtimes][compiler-rt] Add optional runtimes step to build crt up front

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 10:07:52 PDT 2020


daltenty added a comment.

In D88932#2315531 <https://reviews.llvm.org/D88932#2315531>, @phosek wrote:

> See D70744 <https://reviews.llvm.org/D70744> which is trying to achieve the same, but instead it builds crt together with builtins. When I started working on that change, I also considered the approached used in this change and I briefly discussed it with @beanz, but there was a concern that adding more stages is going to increase already long build time even further.

@phosek Thanks, I think it makes a lot of sense to keep it all together in a single stage. It also avoids duplicating a lot of the config which this approach does. I'm not opposed to abandoning this revision if you'd prefer to revive D70744 <https://reviews.llvm.org/D70744> instead then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88932/new/

https://reviews.llvm.org/D88932



More information about the llvm-commits mailing list