[PATCH] D88832: [TableGen] Add new getAllDerivedDefinitionsTwo function to RecordKeeper

Paul C. Anagnostopoulos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 09:47:13 PDT 2020


Paul-C-Anagnostopoulos added a comment.

The problem is that there is no conversion from string literal to StringRef. But I really hesitate to modify every TableGen backend in the system. A backward incompatible change seems dangerous.

Now that I've changed to a SmallVector, I don't think we have to worry about the overhead too much. There are only a few calls to getAllDerivedDefinitions in each backend execution.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88832/new/

https://reviews.llvm.org/D88832



More information about the llvm-commits mailing list