[PATCH] D88940: Add regular expressions to and DWARF Call Frame Information tests in case the architecture specific target is not compiled into LLVM.

[Pavel Labath via Phabricator via llvm-commits]

labath added a comment.

This basically removes the testing for the original patch, since all of these tests would now pass even if the feature is completely reverted. Fortunately, I think the fix for that is easy. We don't need to add the regex to tests that already presuppose that the relevant llvm target is available. By the looks of things, that's everything except `test/DebugInfo/dwarfdump-debug-frame-simple.test`.



================
Comment at: llvm/test/DebugInfo/RISCV/eh-frame.s:29
 # CHECK:   Augmentation data:     1B
-# CHECK:   DW_CFA_def_cfa: X2 +0
+# CHECK:   DW_CFA_def_cfa: {{reg2|X2}} +0
 #
----------------
This test already requires the RISCV target -- see lit.local.cfg.


================
Comment at: llvm/test/MC/ELF/cfi-restore-extended.s:9
   .cfi_restore %rbp
-// CHECK-NEXT: DW_CFA_restore: RBP
+// CHECK-NEXT: DW_CFA_restore: {{reg6|RBP}}
   nop
----------------
This test already requires the X86 target -- see lit.local.cfg. (Also, the `llvm-mc` cmd would not work without that target.)


================
Comment at: llvm/test/MC/Mips/eh-frame.s:69
 // DWARF32-EMPTY:
-// DWARF32-NEXT:     DW_CFA_def_cfa_register: SP_64
+// DWARF32-NEXT:     DW_CFA_def_cfa_register: {{reg29|SP_64}}
 //
----------------
This test requires the mips target -- regex unnecessary.


================
Comment at: llvm/test/MC/X86/i386-darwin-frame-register.ll:14
 ; CHECK-NOT: {{CIE|FDE}}
-; CHECK:   DW_CFA_def_cfa: ESP +4
+; CHECK:   DW_CFA_def_cfa: {{reg4|ESP}} +4
 
----------------
This test requires the x86 target -- regex unnecessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88940/new/

https://reviews.llvm.org/D88940