[PATCH] D88817: [llvm-readobj/elf] - Ignore the hash table when on EM_S390/EM_ALPHA platforms.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

I agree that it doesn't make sense to warn for the hash table not being valid in this context, at least for every invocation. I think a warning when attempting to use it for something specific that cannot be derived from the GNU hash table (or possibly where the GNU hash table is missing) would be useful. It's probably a good idea to have a test case that shows that the warning is NOT produced when the hash table isn't needed for anything.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/hash-table.test:46
+## On EM_S390 and EM_ALPHA platforms we ignore the hash table. We do that because on these platforms the size of entries
+## is 8, what violates the ELF specification, which says that the normal size of hash entries in the hash table must be 4.
+
----------------
(no need to say "normal" - it doesn't provide any cases where it doesn't in the ELF spec)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88817/new/

https://reviews.llvm.org/D88817