[PATCH] D88635: [llvm-readobj] Add --coff-tls-directory flag to print TLS Directory & test.

Wed Oct 7 01:12:56 PDT 2020

grimar added a comment.

I think you can:

1. Merge 7 test cases you have into one (use yaml2obj's `--docnum` option, see examples in `llvm-readobj\ELF\`)
2. Perhaps you can reuse YAMLs with use of yaml2obj's macros feature (-D<macro>=<value>). See `llvm-readobj\ELF\reloc-addends.test` and many other tests.
3. It feels that you should be able to reduce YAML descriptions, e.g. remove excessive sections? (so, try to keep parts that are related/needed only)

================
Comment at: llvm/test/tools/llvm-readobj/COFF/tls-directory-64.test:17
+# CHECK: TLSDirectory {
+# CHECK:   StartAddressOfRawData: 0x140004000
+# CHECK:   EndAddressOfRawData: 0x140004008
----------------
use `CHECK-NEXT` (and in other tests).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88635/new/

https://reviews.llvm.org/D88635