[PATCH] D88945: [ELF] Don't change binding to STB_WEAK for an undefined specified by -u

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 00:48:34 PDT 2020


grimar added inline comments.


================
Comment at: lld/test/ELF/weak-undef-lib.s:23
+# RUN: ld.lld -u foo %t1.o --start-lib %t2.o -o %t1
+# RUN: llvm-readobj --syms %t1 | FileCheck %s --check-prefix=CHECK1
+
----------------
Perhaps, `CHECK1` -> `CHECK-UNDEF` or just `UNDEF`.


================
Comment at: lld/test/ELF/weak-undef-lib.s:27
+# CHECK1:      Section:
+# CHECK1-SAME:          .text
+
----------------
Show binding?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88945/new/

https://reviews.llvm.org/D88945



More information about the llvm-commits mailing list