[PATCH] D88468: [llvm-readobj] Don't print out section names for STABS symbols

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 23:43:00 PDT 2020


grimar added a comment.

In D88468#2314554 <https://reviews.llvm.org/D88468#2314554>, @int3 wrote:

>> You've previously said that "symbols are harder to remove", but I've tried and found it is actually very easy: all you need is to remove a symbol and adjust the nsyms value.
>
> Most of the hassle is in cleaning up the corresponding strings in the string table, but I guess I could have just removed the symbol entries and left the strings in. Anyway, I've cleaned up both now...

I think it could be OK to have a single string, e.g "foo". Probably it is not a problem to use it for all symbols in tests like this,
as all you need to check is that something is dumped or not.

Or, it could be a set of strings of the same sizes, e.g. "foo", "bar", "zed" what would allow to computate string index much easier.
Or, a single large string, like "abcdefghijhklm", but you could use different `n_strx` indices (N...1) so that each symbol got a different name in result ("m". "lm", "klm" etc).

Sure, it is just a problem of yaml2elf COFF that it seems doesn't allow to assing names to symbols easily.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88468/new/

https://reviews.llvm.org/D88468



More information about the llvm-commits mailing list