[PATCH] D88944: [ELF] Skip repeated libraries.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

I am skeptical about the change.

- The duplicated libraries are usually indicator of user errors or build system brittleness.
- The current way the state is introduced is incompatible with the direction on LLD-as-a-library (D88348 <https://reviews.llvm.org/D88348>) (This can be fixed).
- The --verbose now diverges from GNU ld and gold.
- When duplicated libraries happen, the archive index can guarantee that the performance is not degraded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88944/new/

https://reviews.llvm.org/D88944