[PATCH] D85809: [Remarks][1/2] Expand remarks hotness threshold option support in more tools

[Wei Wang via Phabricator via llvm-commits]

weiwang marked 3 inline comments as done.
weiwang added a comment.

Thanks @MaskRay ! I am really sorry I didn't catch up your comments earlier. My email somehow stops giving me notifications on diff updates.



================
Comment at: llvm/include/llvm/Support/CommandLine.h:1484
   explicit opt(const Mods &... Ms)
-      : Option(Optional, NotHidden), Parser(*this) {
+      : Option(llvm::cl::Optional, NotHidden), Parser(*this) {
     apply(this, Ms...);
----------------
MaskRay wrote:
> Unrelated change
This change is need for window msvc build test to pass. Previously the msvc build failed during template instantiation at `cl::opt<Optional<uint64_t>, false, remarks::HotnessThresholdParser>`. The first argument for the base class ctor is an enum type `llvm::cl::Optional`, but msvc somehow tries to map it to `llvm::Optional`. I am not sure why the compiler thinks they are the same. I've tried several ways to fix this, but it only works by explicitly giving its fully qualified name. Linux build does not have this issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85809/new/

https://reviews.llvm.org/D85809