[PATCH] D88877: [ELF] Drop -whole-archive before processing dependent libraries.

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 21:39:47 PDT 2020


ikudrin added inline comments.


================
Comment at: lld/ELF/Driver.cpp:1432
+  // Thus, force the flag off before processing dependent libraries.
+  inWholeArchive = false;
 }
----------------
MaskRay wrote:
> How about moving it to addDependentLibrary? Then you can have much shorter comment.
`inWholeArchive` is a private member of `LinkerDriver`, it cannot be accessed from `addDependentLibrary()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88877/new/

https://reviews.llvm.org/D88877



More information about the llvm-commits mailing list