[PATCH] D88924: [X86] Move findDeadCallerSavedReg() into X86RegisterInfo

Scott Constable via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 20:07:41 PDT 2020


sconstab marked an inline comment as done.
sconstab added inline comments.


================
Comment at: llvm/lib/Target/X86/X86RegisterInfo.cpp:797
+                                        MachineBasicBlock::iterator &MBBI,
+                                        bool Is64Bit) const {
+  const MachineFunction *MF = MBB.getParent();
----------------
craig.topper wrote:
> I was going to ask if you could just use the Is64Bit member in X86RegisterInfo. But it doesn't look like this argument is used at all.
Well, the parameter isn't used, but I did notice that the member is used in the call to `getGPRsForTailCall()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88924/new/

https://reviews.llvm.org/D88924



More information about the llvm-commits mailing list