[PATCH] D84380: [lit] Support running tests on Windows without GnuWin32.

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In D84380#2315380 <https://reviews.llvm.org/D84380#2315380>, @hans wrote:

> To me this seems to have added an extra dimension. Previously, lit would look for the tools on PATH, now it was made to look in two places.

What I really wanted to do was remove support for using PATH entirely.  I was worried about breaking downstream users (and in this case my worry was justified).  At the same time, we should not hold the open-source project back because of problems with downstream users' environments.  What we should aim for is a completely hermetic environment, which will never be achievable with a dependence on PATH.

By reverting this, we are going to be stuck with a required dependency on a project that has been unmaintained for close to a decade with no path forward.  That doesn't seem like the right direction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84380/new/

https://reviews.llvm.org/D84380