[PATCH] D87531: [LoopNest] Extend `LPMUpdater` and adaptor to handle loop-nest passes

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:244
+/// loops are contained in the worklist and the addition of new (top-level)
+/// loops will no trigger the addition of their subloops.
 class LPMUpdater {
----------------
s/will no/will not


================
Comment at: llvm/include/llvm/Transforms/Scalar/LoopPassManager.h:266
   void markLoopAsDeleted(Loop &L, llvm::StringRef Name) {
+    assert(!(LoopNestMode && L.getParentLoop()) &&
+           "L should be a top-level loop in loop-nest mode.");
----------------
legibility:
`(!LoopNestMode || !L.getParentLoop())`
or more detailed
`(!LoopNestMode || (LoopNestMode && !L.getParentLoop()))`
?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87531/new/

https://reviews.llvm.org/D87531